Update to be compatible with React 15.4 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone please merge this PR? Now that React 15.4 is published on NPM... cc @madjam002 |
|
+1 |
|
I don't want to be rude or anything, but I'm not sure all the +1 are really that helpful. If you want to voice your support, it is possible to add your reaction to the initial post. This way, people subscribing to the issue won't be spammed for nothing. 😅 |
|
|
|
Yes. We've heard you. Spamming the thread with +1 has absolutely no effect other than annoying people. Replacing the imports didn't fix the plugin. I found the issue and I'm currently preparing a new release. |
|
Thank you for quick response! |
petetnt
added a commit
to petetnt/admin-on-rest
that referenced
this pull request
Nov 17, 2016
... to fix React 15.4.0 compatibility). [react-v15.4.0](https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html) broke `react-tap-event-plugin@v1`, which got updated to 2.0.1. just now at zilverline/react-tap-event-plugin#82. See the change set here: https://github.com/zilverline/react-tap-event-plugin/pull/82/files. It only changes the paths to `react-dom`. https://www.npmjs.com/package/react-tap-event-plugin
This was referenced Nov 17, 2016
Closed
petetnt
added a commit
to petetnt/admin-on-rest
that referenced
this pull request
Nov 18, 2016
... to fix React 15.4.0 compatibility). [react-v15.4.0](https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html) broke `react-tap-event-plugin@v1`, which got updated to 2.0.1. just now at zilverline/react-tap-event-plugin#82. See the change set here: https://github.com/zilverline/react-tap-event-plugin/pull/82/files. It only changes the paths to `react-dom`. https://www.npmjs.com/package/react-tap-event-plugin Update React too for correct peer deps Signed-off-by: petetnt <pete.a.nykanen@gmail.com>
fzaninotto
pushed a commit
to petetnt/admin-on-rest
that referenced
this pull request
Nov 30, 2016
... to fix React 15.4.0 compatibility). [react-v15.4.0](https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html) broke `react-tap-event-plugin@v1`, which got updated to 2.0.1. just now at zilverline/react-tap-event-plugin#82. See the change set here: https://github.com/zilverline/react-tap-event-plugin/pull/82/files. It only changes the paths to `react-dom`. https://www.npmjs.com/package/react-tap-event-plugin Update React too for correct peer deps Signed-off-by: petetnt <pete.a.nykanen@gmail.com>
Granddevv
added a commit
to Granddevv/React-Admin-panel-restful-apis-
that referenced
this pull request
Jan 15, 2018
... to fix React 15.4.0 compatibility). [react-v15.4.0](https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html) broke `react-tap-event-plugin@v1`, which got updated to 2.0.1. just now at zilverline/react-tap-event-plugin#82. See the change set here: https://github.com/zilverline/react-tap-event-plugin/pull/82/files. It only changes the paths to `react-dom`. https://www.npmjs.com/package/react-tap-event-plugin
Granddevv
added a commit
to Granddevv/React-Admin-panel-restful-apis-
that referenced
this pull request
Jan 15, 2018
... to fix React 15.4.0 compatibility). [react-v15.4.0](https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html) broke `react-tap-event-plugin@v1`, which got updated to 2.0.1. just now at zilverline/react-tap-event-plugin#82. See the change set here: https://github.com/zilverline/react-tap-event-plugin/pull/82/files. It only changes the paths to `react-dom`. https://www.npmjs.com/package/react-tap-event-plugin Update React too for correct peer deps Signed-off-by: petetnt <pete.a.nykanen@gmail.com>
coderbag
added a commit
to coderbag/admin-on-rest
that referenced
this pull request
Jan 20, 2018
... to fix React 15.4.0 compatibility). [react-v15.4.0](https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html) broke `react-tap-event-plugin@v1`, which got updated to 2.0.1. just now at zilverline/react-tap-event-plugin#82. See the change set here: https://github.com/zilverline/react-tap-event-plugin/pull/82/files. It only changes the paths to `react-dom`. https://www.npmjs.com/package/react-tap-event-plugin
coderbag
added a commit
to coderbag/admin-on-rest
that referenced
this pull request
Jan 20, 2018
... to fix React 15.4.0 compatibility). [react-v15.4.0](https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html) broke `react-tap-event-plugin@v1`, which got updated to 2.0.1. just now at zilverline/react-tap-event-plugin#82. See the change set here: https://github.com/zilverline/react-tap-event-plugin/pull/82/files. It only changes the paths to `react-dom`. https://www.npmjs.com/package/react-tap-event-plugin Update React too for correct peer deps Signed-off-by: petetnt <pete.a.nykanen@gmail.com>
smartgru
pushed a commit
to smartgru/react-admin-panel
that referenced
this pull request
Dec 5, 2018
... to fix React 15.4.0 compatibility). [react-v15.4.0](https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html) broke `react-tap-event-plugin@v1`, which got updated to 2.0.1. just now at zilverline/react-tap-event-plugin#82. See the change set here: https://github.com/zilverline/react-tap-event-plugin/pull/82/files. It only changes the paths to `react-dom`. https://www.npmjs.com/package/react-tap-event-plugin
smartgru
pushed a commit
to smartgru/react-admin-panel
that referenced
this pull request
Dec 5, 2018
... to fix React 15.4.0 compatibility). [react-v15.4.0](https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html) broke `react-tap-event-plugin@v1`, which got updated to 2.0.1. just now at zilverline/react-tap-event-plugin#82. See the change set here: https://github.com/zilverline/react-tap-event-plugin/pull/82/files. It only changes the paths to `react-dom`. https://www.npmjs.com/package/react-tap-event-plugin Update React too for correct peer deps Signed-off-by: petetnt <pete.a.nykanen@gmail.com>
smartgru
added a commit
to smartgru/react-admin-panel
that referenced
this pull request
Aug 14, 2021
... to fix React 15.4.0 compatibility). [react-v15.4.0](https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html) broke `react-tap-event-plugin@v1`, which got updated to 2.0.1. just now at zilverline/react-tap-event-plugin#82. See the change set here: https://github.com/zilverline/react-tap-event-plugin/pull/82/files. It only changes the paths to `react-dom`. https://www.npmjs.com/package/react-tap-event-plugin
smartgru
added a commit
to smartgru/react-admin-panel
that referenced
this pull request
Aug 14, 2021
... to fix React 15.4.0 compatibility). [react-v15.4.0](https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html) broke `react-tap-event-plugin@v1`, which got updated to 2.0.1. just now at zilverline/react-tap-event-plugin#82. See the change set here: https://github.com/zilverline/react-tap-event-plugin/pull/82/files. It only changes the paths to `react-dom`. https://www.npmjs.com/package/react-tap-event-plugin Update React too for correct peer deps Signed-off-by: petetnt <pete.a.nykanen@gmail.com>
DarkNight918
added a commit
to DarkNight918/admin-on-rest
that referenced
this pull request
Mar 21, 2023
... to fix React 15.4.0 compatibility). [react-v15.4.0](https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html) broke `react-tap-event-plugin@v1`, which got updated to 2.0.1. just now at zilverline/react-tap-event-plugin#82. See the change set here: https://github.com/zilverline/react-tap-event-plugin/pull/82/files. It only changes the paths to `react-dom`. https://www.npmjs.com/package/react-tap-event-plugin
DarkNight918
added a commit
to DarkNight918/admin-on-rest
that referenced
this pull request
Mar 21, 2023
... to fix React 15.4.0 compatibility). [react-v15.4.0](https://facebook.github.io/react/blog/2016/11/16/react-v15.4.0.html) broke `react-tap-event-plugin@v1`, which got updated to 2.0.1. just now at zilverline/react-tap-event-plugin#82. See the change set here: https://github.com/zilverline/react-tap-event-plugin/pull/82/files. It only changes the paths to `react-dom`. https://www.npmjs.com/package/react-tap-event-plugin Update React too for correct peer deps Signed-off-by: petetnt <pete.a.nykanen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per facebook#7770 some dependencies in React 15.4 were moved from react/lib/ to react-dom/lib/.