Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAM conversion #626

Merged
merged 3 commits into from
Feb 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 12 additions & 20 deletions zio-kafka/src/main/scala/zio/kafka/producer/Producer.scala
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
package zio.kafka.producer

import org.apache.kafka.clients.producer.{
Callback,
KafkaProducer,
Producer => JProducer,
ProducerRecord,
RecordMetadata
}
import org.apache.kafka.clients.producer.{ KafkaProducer, Producer => JProducer, ProducerRecord, RecordMetadata }
import org.apache.kafka.common.serialization.ByteArraySerializer
import org.apache.kafka.common.{ Metric, MetricName }
import zio._
Expand Down Expand Up @@ -175,19 +169,17 @@ object Producer {

p.send(
rec,
new Callback {
def onCompletion(metadata: RecordMetadata, err: Exception): Unit =
Unsafe.unsafe { implicit u =>
(if (err != null) runtime.unsafe.run(done.fail(err)).getOrThrowFiberFailure(): Unit
else {
res(idx) = metadata
if (count.incrementAndGet == length) {
runtime.unsafe.run(done.succeed(Chunk.fromArray(res))).getOrThrowFiberFailure(): Unit
}
}): @nowarn("msg=discarded non-Unit value")
()
}
}
(metadata: RecordMetadata, err: Exception) =>
Unsafe.unsafe { implicit u =>
(if (err != null) runtime.unsafe.run(done.fail(err)).getOrThrowFiberFailure(): Unit
else {
res(idx) = metadata
if (count.incrementAndGet == length) {
runtime.unsafe.run(done.succeed(Chunk.fromArray(res))).getOrThrowFiberFailure(): Unit
}
}): @nowarn("msg=discarded non-Unit value")
()
}
)
}
}
Expand Down
6 changes: 2 additions & 4 deletions zio-kafka/src/main/scala/zio/kafka/serde/Deserializer.scala
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,8 @@ object Deserializer extends Serdes {
/**
* Create a deserializer from a function
*/
def apply[R, T](deser: (String, Headers, Array[Byte]) => RIO[R, T]): Deserializer[R, T] = new Deserializer[R, T] {
override def deserialize(topic: String, headers: Headers, data: Array[Byte]): RIO[R, T] =
deser(topic, headers, data)
}
def apply[R, T](deser: (String, Headers, Array[Byte]) => RIO[R, T]): Deserializer[R, T] =
(topic: String, headers: Headers, data: Array[Byte]) => deser(topic, headers, data)

/**
* Create a Deserializer from a Kafka Deserializer
Expand Down
5 changes: 1 addition & 4 deletions zio-kafka/src/main/scala/zio/kafka/serde/Serializer.scala
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,7 @@ object Serializer extends Serdes {
* Create a serializer from a function
*/
def apply[R, T](ser: (String, Headers, T) => RIO[R, Array[Byte]]): Serializer[R, T] =
new Serializer[R, T] {
override def serialize(topic: String, headers: Headers, value: T): RIO[R, Array[Byte]] =
ser(topic, headers, value)
}
(topic: String, headers: Headers, value: T) => ser(topic, headers, value)

/**
* Create a Serializer from a Kafka Serializer
Expand Down