-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added delegate for the new finish method that's in RN 0.38 which calls the completion handler #277
Conversation
Now that RN 0.38 is released is anyone able to review this PR for me? I use it in production from my fork, as far as I can see its works well. |
@zo0r hey - would you mind reviewing this? It's a small change, required for iOS only (does nothing on android). RN38 changed the method thats called when receiving a push notification. The purpose is to add a mechanism that tells the OS that the app has finished processing the notification. I've added a Without this change, the OS can penalise you app and will stop delivering notifications. |
+1 to merge this @zo0r |
@zo0r i've been using this in my app for a while, I think it's safe to merge. |
+1 here please @zo0r, I have this monkey patched in my app atm :/ |
I need it too |
@zo0r, what's the problem here to merge this PR? |
@zo0r, thanks and what about npm release? |
Thank you! no more monkey patching! I was about to fork this last week and publish it to npm because sometimes I'd forget to remonkey patch 👍 |
@tonygriv @eddnav |
facebook/react-native#8040