Replies: 2 comments
-
We've had an unusual bug with the transcription task during beta test which is causing duplicate marks missing sub-task text annotations to be created intermittently for some users. We only caught this because of downstream failures in aggregation. One possible explanation is that something unusual is happening with both PEP and React's handling of the pointer events and duplicating its handling (only sometimes?). I've not been able to replicate the issue, so this is only a guess and since we should remove PEP anyway, I'm going to open a PR to see what happens when it is removed. |
Beta Was this translation helpful? Give feedback.
-
Removed in #2049 |
Beta Was this translation helpful? Give feedback.
-
The PEP pointer events polyfill has entered emeritus status: https://openjsf.org/blog/2021/02/10/pointer-events-polyfill-pep-enters-emeritus-status-at-the-openjs-foundation/
Our own internal policy is to support current version and most recent browser version. The pointer events API is almost entirely supported starting at iOS 13 and fully supported at 13.2 (https://caniuse.com/pointer), which means we're within our own policy to drop the polyfill.
We've also been getting errors in Sentry that get thrown in the PEP library, for example:
https://sentry.io/organizations/zooniverse-27/issues/1537700688/?project=1492691&query=is%3Aunresolved
Given that all modern browsers support the pointer events API, its emeritus status, and that some of the errors we see reported may be caused by the polyfill, should we remove it?
One reason to maybe hold off is that our google analytics still show roughly 450 site users on iOS 12 still: https://analytics.google.com/analytics/web/#/report/visitors-mobile-devices/a1224199w25826018p97262563/explorer-table.plotKeys=%5B%5D&_r.drilldown=analytics.operatingSystem:iOS
That's roughly 5% of the ~55% of iOS users of the mobile/tablet user group (25% of total). This is pretty small and I propose that this shouldn't stop us.
The emeritus statement also encourages the discontinue usage of it:
Should we stop using this polyfill at risk of cutting off some features to the remaining iOS 12 users?
Beta Was this translation helpful? Give feedback.
All reactions