Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PEP #2049

Merged
merged 3 commits into from
Mar 1, 2021
Merged

Remove PEP #2049

merged 3 commits into from
Mar 1, 2021

Conversation

srallen
Copy link
Contributor

@srallen srallen commented Feb 25, 2021

Please request review from @zooniverse/frontend team. If PR is related to design, please request review from @beckyrother in addition.

Package: lib-classifier

PEP is entering a kind of EOL (see #2035) and I'm suspecting it may be the cause of a few Sentry reported bugs and potentially a silent bug with an occasional duplicate mark being created with the transcription line tool. I haven't been able to replicate the issue of duplicate marks, but we're gonna try this out since we have to do this anyway.

There shouldn't be any regressions, other than support for Safari 12 is dropped, but to double check anyway: https://localhost:8080/?project=1764&workflow=3392

Review Checklist

General

  • Are the tests passing locally and on Travis?
  • Is the documentation up to date?

Components

Apps

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you yarn panic && yarn bootstrap or docker-compose up --build and app works as expected?

Publishing

  • Is the changelog updated?
  • Are the dependencies updated for apps and libraries that are using the newly published library?

Post-merging

@srallen srallen added bug Something isn't working dependencies Pull requests that update a dependency file labels Feb 25, 2021
@srallen srallen requested a review from a team February 25, 2021 20:02
Copy link
Contributor

@eatyourgreens eatyourgreens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. The touch-action attribute can be removed from the HTML too.

@github-actions github-actions bot added the approved This PR is approved for merging label Feb 26, 2021
@srallen srallen merged commit 4edcf00 into master Mar 1, 2021
@srallen srallen deleted the remove-pep branch March 1, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved for merging bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants