Dev classifier workflow routing #2993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some simple workflow routing to the dev classifier, so that the location bar updates when the selected workflow changes.
eatyourgreens
added
enhancement
18 tasks
Add history state for back/forward navigation.
eatyourgreens
force-pushed
the
dev-classifier-routing
branch
from
6e9a466
to
c6fe331
Compare
- use `htmlFor` instead of `for`. - use keys for arrays of JSX elements. - use `defaultValue` instead of `selected`.
ErikOstlund
reviewed
Mar 31, 2022
| <select id="workflows" onChange={this.selectWorkflow}> | ||
| <option selected={!workflowID} value=''>None</option> | ||
| {workflows.map(workflow => <option selected={workflow.id === workflowID} value={workflow.id}>{workflow.display_name} {workflow.id}</option>)} | ||
| <label htmlFor="workflows">Change workflow</label> |
ErikOstlund
reviewed
Mar 31, 2022
| <label htmlFor="workflows">Change workflow</label> | ||
| <select id="workflows" defaultValue={workflowID} onChange={this.selectWorkflow}> | ||
| <option value=''>None</option> | ||
| {workflows.map(workflow => <option key={workflow.id} value={workflow.id}>{workflow.display_name} {workflow.id}</option>)} |
There was a problem hiding this comment.
Missing key: Nice catch!
ErikOstlund
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some simple workflow routing to the dev classifier, so that the location bar updates when the selected workflow changes.
I've also fixed a few React errors in the console:
htmlForinstead offorin JSX.defaultValueinstead ofselectedfor the<select>element.Try it out on a project that has multiple workflows. When you select a new workflow, from the dropdown menu, the window location should update to include the new value of the
workflowquery parameter. I've also added apopstatehandler so that you can navigate backwards and forwards with the browser Back and Forward buttons.https://localhost:8080/?project=eatyourgreens%2F-project-testing-ground
Package
lib-classifier
Checklist
PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.
General
yarn panic && yarn bootstrapordocker-compose up --buildand FEM works as expectedGeneral UX
Example Staging Project: i-fancy-cats
Bug Fix
New Feature
Refactoring
Maintenance