Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment: remove session caching #4917

Closed
wants to merge 1 commit into from
Closed

Conversation

eatyourgreens
Copy link
Contributor

This is an experimental build, using an API client that doesn't cache Panoptes user sessions.

Package

  • app-content-pages
  • app-project

Linked Issue and/or Talk Post

How to Review

Helpful explanations that will make your reviewer happy:

  • What Zooniverse project should my reviewer use to review UX?
  • What user actions should my reviewer step through to review this PR?
  • Which storybook stories should be reviewed?
  • Are there plans for follow up PR’s to further fix this bug or develop this feature?

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
  • FEM works in a mobile browser

General UX

Example Staging Project: i-fancy-cats

  • All pages of a FEM project load: Home Page, Classify Page, and About Pages
  • Can submit a classification
  • Can sign-in and sign-out
  • The component is accessible

Bug Fix

  • The PR creator has listed user actions to use when testing if bug is fixed
  • The bug is fixed
  • Unit tests are added or updated

@eatyourgreens eatyourgreens added the bug Something isn't working label Jun 29, 2023
@coveralls
Copy link

coveralls commented Jun 29, 2023

Coverage Status

coverage: 82.011% (+0.002%) from 82.009% when pulling 7444787 on auth-session-caching into d538475 on master.

@eatyourgreens eatyourgreens force-pushed the auth-session-caching branch 2 times, most recently from a9aca21 to bbdcf63 Compare June 29, 2023 14:28
@eatyourgreens
Copy link
Contributor Author

I'm still seeing #4892 on this branch.

This is an experimental build, using an API client that doesn't cache Panoptes user sessions.

- See zooniverse/panoptes-javascript-client#208.
@eatyourgreens
Copy link
Contributor Author

On this branch, visibility change resets any unfinished annotations, destroying work in progress on transcription subjects.

@eatyourgreens
Copy link
Contributor Author

Login/logout is also broken on this branch. 🙁

@eatyourgreens eatyourgreens deleted the auth-session-caching branch July 3, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

2 participants