Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add axis layer test #968

Merged
merged 6 commits into from
Jul 24, 2019
Merged

Add axis layer test #968

merged 6 commits into from
Jul 24, 2019

Conversation

srallen
Copy link
Contributor

@srallen srallen commented Jul 1, 2019

Package: lib-classifier

For #650

Describe your changes:
Adds unit tests for addAxisLayer

Review Checklist

General

  • Are the tests passing locally and on Travis?
  • Is the documentation up to date?
  • Is the changelog updated?

Apps

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you rm -rf node_modules/ && npm install and app works as expected?

@srallen srallen added the refactor Refactoring existing code label Jul 1, 2019
@srallen srallen added this to the LCV Refactor milestone Jul 1, 2019
@srallen srallen requested a review from a team July 1, 2019 18:43
@mcbouslog mcbouslog self-assigned this Jul 24, 2019
mcbouslog
mcbouslog approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@mcbouslog mcbouslog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tests built straightforwardly, even with limited d3 understanding, how the axis-layer was built for testing and specific properties tested is easy to follow.

@mcbouslog mcbouslog mentioned this pull request Jul 24, 2019
Merged
6 tasks
@mcbouslog mcbouslog merged commit 6ed7b91 into master Jul 24, 2019
@mcbouslog mcbouslog deleted the add-axis-layer-test branch July 24, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcbouslog mcbouslog mcbouslog approved these changes

Assignees

@mcbouslog mcbouslog

Labels
refactor Refactoring existing code
Projects
None yet
Milestone
LCV Refactor
Development

Successfully merging this pull request may close these issues.
2 participants
@srallen @mcbouslog