Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Mocha tests to ESM #232

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Conversation

eatyourgreens
Copy link
Contributor

Chai 5 is import only (ESM), so this converts the mocha tests to .mjs.

Chai 5 is `import` only (ESM), so this converts the mocha tests to `.mjs`.
@eatyourgreens
Copy link
Contributor Author

eatyourgreens commented Jan 25, 2024

Tests are failing because the stats service is down, which might be a permanent change. See #233.

@mcbouslog mcbouslog self-assigned this Jan 26, 2024
@mcbouslog mcbouslog self-requested a review January 26, 2024 15:42
@eatyourgreens eatyourgreens mentioned this pull request Jan 26, 2024
@mcbouslog mcbouslog merged commit 588c8a0 into zooniverse:main Jan 29, 2024
3 checks passed
@eatyourgreens eatyourgreens deleted the esm-tests branch January 29, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants