Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent notification emails from being sent to user's with invalid email #316

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

Tooyosi
Copy link
Contributor

@Tooyosi Tooyosi commented Apr 2, 2024

Solves for this issue: #312

@Tooyosi Tooyosi requested review from zwolf and lcjohnso April 2, 2024 11:53
Copy link
Member

@zwolf zwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! This also needs the same short circuit logic added to the DigestEmailWorker to prevent users with invalid emails from getting digest emails, also.

@Tooyosi
Copy link
Contributor Author

Tooyosi commented Apr 18, 2024

DigestEmailWorker

I'm sorry, just seeing your comment. I'm seeing this line in the digest email worker, would this fix not suffice for it aswell? Since the valid_email check is made on the NotificationEmailWorker?

Copy link
Member

@zwolf zwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, actually you're totally right, looks like every emailer eventually calls NotificationEmailWorker. LGTM!

@Tooyosi Tooyosi merged commit 0bf19bb into master Apr 18, 2024
1 check passed
@Tooyosi Tooyosi deleted the 312-add-valid_email-check-to-mailer branch April 18, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants