-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display daemon messages on standard error #2150
Conversation
Signed-off-by: Gene Johnston <Eugene.Johnston@broadcom.com>
Signed-off-by: Gene Johnston <eugene.johnston@broadcom.com>
Signed-off-by: Gene Johnston <Eugene.Johnston@broadcom.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2150 +/- ##
========================================
Coverage 91.21% 91.21%
========================================
Files 628 628
Lines 17891 17891
Branches 3689 3793 +104
========================================
Hits 16319 16319
Misses 1571 1571
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Gene!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @gejohnston!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @gejohnston, thank you!
Release failed for the
Check the workflow run for more error details. Powered by Octorelease 🚀 |
Release failed for the
Check the workflow run for more error details. Powered by Octorelease 🚀 |
What It Does
The zowe executable, which controls the daemon, now sends all informational messages, progress messages, and error messages to standard error instead of standard output.
How to Test
On Linux, you can run a command that starts the daemon and observe that the "starting" message goes to standard error.
On Windows, redirecting stdout or stderr on a Zowe command when the daemon is being started locks stdout and stderr until the daemon process is terminated. The Zowe command hangs until the daemon is terminated. This is existing daemon behavior. Instead, run one Zowe command just to start the daemon. You can then redirect stdout and stderr on subsequent Zowe commands.
You can also confirm that the daemon's executable version number continues to be displayed on standard output.
Review Checklist
I certify that I have:
Additional Comments
Similar system tests fail on the master branch when run as daemon. My conclusion is that the system tests have not been affected by this change.