Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove suggestion on complete #149

Closed
wants to merge 1 commit into from
Closed

Remove suggestion on complete #149

wants to merge 1 commit into from

Conversation

seletskiy
Copy link

No description provided.

@seletskiy seletskiy force-pushed the remove-suggestion-on-complete branch from 2ee7e6d to d9ff234 Compare April 22, 2016 05:51
@ericfreese
Copy link
Member

What problem is this solving?

@seletskiy
Copy link
Author

Before:
zsh-sug-before

After:
zsh-sug-after

ericfreese added a commit that referenced this pull request Apr 25, 2016
@ericfreese
Fix 118: Clear suggestion before original widget to fix completions
e87bc74 
See PR #149
@ericfreese
Copy link
Member

Ok. It sounds like you're describing #118. I think this is a good solution. Commit e87bc74 should implement the same behavior, using unset instead of setting it to an empty string and including a comment.

Thanks!

@ericfreese ericfreese closed this Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seletskiy @ericfreese