Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable autosuggest if buffer is too large #177

Closed
wants to merge 1 commit into from

Conversation

lbolla
Copy link
Contributor

@lbolla lbolla commented Jul 15, 2016

This is a workaround when copying large amount of texts in a terminal, i.e. with mouse-button-2.
The idea is to disable autosuggestion when buffer is too large. This avoids that the autosuggest function is called too many times (it's called once per character), slowing it down the paste.
I hardcoded the max buffer length to 20 chars. Possibly, it could be a configurable value instead.

@ericfreese
Copy link
Member

ericfreese commented Jul 16, 2016

I'd be open to merging this in if you make it a configurable field with a default of no limit. Can you make that change, add a test to cover it, and submit a separate PR, this time to the develop branch instead of master?

Thanks!

@ericfreese ericfreese closed this Jul 16, 2016
@lbolla
Copy link
Contributor Author

lbolla commented Jul 18, 2016

Submitted new PR #178.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants