Make ComposeBox uncontrolled on iOS too, and dedupe code #3017
Assignees
Labels
Comments
gnprice
added
a-iOS
a-compose/send
This was referenced Oct 2, 2018
gnprice
added
a-compose/send
borisyankov
added a commit
to borisyankov/zulip-mobile
that referenced
this issue
Nov 1, 2018
Resolves zulip#3017, Fixes zulip#2434, Fixes zulip#3053 Remove the iOS code which was our old 'controlled' version and keep the new Android 'uncontrolled' version. While iOS does not have the extreme performance issues the Android app had because of bugs in React Native, it is still faster to not have the component controlled - a controlled compoennt would block any time the UI thread blocks. Another big benefit is removing the need to support two versions.
borisyankov
added a commit
to borisyankov/zulip-mobile
that referenced
this issue
Nov 1, 2018
Resolves zulip#3017, Fixes zulip#2434, Fixes zulip#3053 Remove the iOS code which was our old 'controlled' version and keep the new Android 'uncontrolled' version. While iOS does not have the extreme performance issues the Android app had because of bugs in React Native, it is still faster to not have the component controlled - a controlled compoennt would block any time the UI thread blocks. Another big benefit is removing the need to support two versions.
borisyankov
added a commit
to borisyankov/zulip-mobile
that referenced
this issue
Nov 1, 2018
Closes zulip#3017. Fixes zulip#2434. Fixes zulip#3053. Remove the iOS code which was our old 'controlled' version and keep the new Android 'uncontrolled' version. While iOS does not have the extreme performance issues the Android app had because of bugs in React Native, it is still faster to not have the component controlled - a controlled compoennt would block any time the UI thread blocks. Another big benefit is removing the need to support two versions.
gnprice
pushed a commit
to borisyankov/zulip-mobile
that referenced
this issue
Nov 1, 2018
Closes zulip#3017. Fixes zulip#3053. Remove the iOS code which was our old 'controlled' version and keep the new Android 'uncontrolled' version. While iOS does not have the extreme performance issues the Android app had because of bugs in React Native, it is still faster to not have the component controlled - a controlled component would block any time the UI thread blocks. Another big benefit is removing the need to support two versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We duplicated this code as a temporary expedient in cb2589e (from #2738), because we needed to make the message and topic inputs uncontrolled on Android but leave them controlled on iOS, in order to simultaneously avoid two different React Native bugs that affected the two platforms respectively. See the above-mentioned commit and PR for details.
As we've known since then, we should de-duplicate them; we want uncontrolled inputs on both platforms. #2886 was one PR to do this, but its clever workaround for the RN bug that had blocked us the first time turned out to not always succeed.
Fortunately, RN 0.57 has a fix for that bug. So once that upgrade is done, this should be easy. See #2788 for the 0.56 upgrade, which looks like most of the work.
The text was updated successfully, but these errors were encountered: