Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show which topics are followed #5770

Closed
alya opened this issue Sep 28, 2023 · 1 comment · Fixed by #5793
Closed

Show which topics are followed #5770

alya opened this issue Sep 28, 2023 · 1 comment · Fixed by #5793
Assignees
@gnprice
Labels
server release goal Things we should try to coordinate with a major Zulip Server release. webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.

Comments

@alya
Copy link
Collaborator

alya commented Sep 28, 2023

In the web app, we indicate followed topics with a dedicated icon (see here).

We should also indicate followed topics with an icon in the mobile app, in the Inbox view (probably the most useful placement), as well as the app bar in topic views and topic header bars.
@alya alya added webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity. server release goal Things we should try to coordinate with a major Zulip Server release. labels Sep 28, 2023
@gnprice gnprice mentioned this issue Oct 4, 2023
Merged
@chrisbobbe chrisbobbe mentioned this issue Nov 1, 2023
Closed
@gnprice
Copy link
Member

gnprice commented Nov 8, 2023

The mobile app is already tracking the data needed for this: getTopicVisibilityPolicy is the selector to get it from the state. So what's needed in order to do this is:

  • Get the "followed topic" icon into our tree. (And the "unmuted" / "default visibility" / "muted" icons, if we want to show any of those?)
  • Add it in the several places in the UI mentioned in the description above.
    • This may involve making some visual-design choices about precisely how to show it: how big, where, with what padding, etc.

gnprice added a commit to gnprice/zulip-mobile that referenced this issue Nov 16, 2023
@gnprice
follow-topic: Show "follow" icon in recipient headers
6ae2038 
Together with the preceding few commits which add this icon in
some other places in the UI, this completes zulip#5770.

Fixes: zulip#5770
@gnprice gnprice self-assigned this Nov 16, 2023
@gnprice gnprice mentioned this issue Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnprice gnprice

Labels
server release goal Things we should try to coordinate with a major Zulip Server release. webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.
Projects
No open projects
Zulip Server 8.0 priorities
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show "followed topic" icon in several places gnprice/zulip-mobile
2 participants
@gnprice @alya