Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add form to Blog App #7

Merged
merged 7 commits into from
Dec 9, 2023
Merged

Add form to Blog App #7

merged 7 commits into from
Dec 9, 2023

Conversation

zunairkhan811
Copy link
Owner

  • Add current_user method in Application Controller
  • Add post-creation form using current_user
  • Add comment creation form
  • Add Like form
  • Fix linter errors

Copy link

@Munsa1 Munsa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zunairkhan811,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Created Forms ✔️
Correct Git Flow ✔️
Descriptive ReadMe File ✔️

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:
N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

app/controllers/posts_controller.rb Show resolved Hide resolved
app/controllers/comments_controller.rb Show resolved Hide resolved
app/controllers/comments_controller.rb Show resolved Hide resolved
app/controllers/likes_controller.rb Show resolved Hide resolved
Copy link

@topeogunleye topeogunleye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zunairkhan811,

Status: Approved ✔️

Excellent job on making the changes requested by the previous code reviewer. Keep it up 👏

Your project is complete! There is nothing else to say other than... it's time to merge it 💪
Congratulations! 🎉
congratulations

To highlight 🍾

  1. ApplicationController - current_user Method:

    • The current_user method in the ApplicationController returns the first user, providing a basic implementation for tracking the current user.
  2. PostsController - New & Create Actions:

    • The PostsController effectively implements the new and create actions.
    • The create action handles post creation, utilizing @current_user for association and responding appropriately based on success or failure.
  3. Routes for Posts:

    • Routes for creating posts are correctly configured in config/routes.rb.
  4. Post Creation Form:

    • The views/posts/new.html.erb file contains a form for accepting post creation input.
  5. CommentsController - New & Create Actions:

    • The CommentsController appropriately handles the new and create actions.
    • Comment creation involves associating the comment with the current user and the corresponding post.
  6. Routes for Comments:

    • Routes for creating comments are correctly configured in config/routes.rb.
  7. Comment Creation Form:

    • The views/comments/new.html.erb file contains a form for accepting comment creation input.
  8. LikesController - Create Action:

    • The LikesController has an effective create action for adding likes to posts.
  9. Route for Likes:

    • The route for creating likes is correctly configured in config/routes.rb.

[Optional] suggestions:

  • Please check my inline comments.

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag @topeogunleye in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@zunairkhan811 zunairkhan811 merged commit 1a45341 into development Dec 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants