Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration spec for view and fix N+1 Issues #8

Merged
merged 8 commits into from
Dec 12, 2023

Conversation

zunairkhan811
Copy link
Owner

  • Before Fixing N+1 Issues screenshot

beforecorrection

  • After Fixing N+1 Issues screenshot

aftercorrection

  • Write Integrations Tests with Capabara for Views

Project Requirements:

  • User index page:

    I can see the username of all other users.
    I can see the profile picture for each user.
    I can see the number of posts each user has written.
    When I click on a user, I am redirected to that user's show page.
    
  • user show page:

    I can see the user's profile picture.
    I can see the user's username.
    I can see the number of posts the user has written.
    I can see the user's bio.
    I can see the user's first 3 posts.
    I can see a button that lets me view all of a user's posts.
    When I click a user's post, it redirects me to that post's show page.
    When I click to see all posts, it redirects me to the user's post's index page.
    
  • User post index page:

    I can see the user's profile picture.
    I can see the user's username.
    I can see the number of posts the user has written.
    I can see a post's title.
    I can see some of the post's body.
    I can see the first comments on a post.
    I can see how many comments a post has.
    I can see how many likes a post has.
    I can see a section for pagination if there are more posts than fit on the view.
    When I click on a post, it redirects me to that post's show page.
    
  • Post show page:

    I can see the post's title.
    I can see who wrote the post.
    I can see how many comments it has.
    I can see how many likes it has.
    I can see the post body.
    I can see the username of each commentor.
    I can see the comment each commentor left.
    

Copy link

@Reem-lab Reem-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zunairkhan811 and @nilab-khwaja, 👋🏻👋🏻

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • Followed Gitflow 💯
  • Descriptive PR⭐
  • No Linters error ✅
  • Kudos for working on the tests for views🤩
  • Great job on fixing the N+1 problem 🔥

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@zunairkhan811 zunairkhan811 merged commit 1248b00 into development Dec 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants