Improving the style of tabs #347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am satisfied with how it looks now. I would appreciate if people could check how it looks on their system. I have not tested on mac and linux, so it would be especially good to get feedback for those. |
|
Tagging @boldar99 @y-richie-y for mac |
|
For me, this is how it looks: |
|
What's that horizontal line passing through the tabs? Also the tabs are centered on Mac for some reason. This makes the lack of a left tab border look a bit strange. |
|
Can you also check if the effects of hovering on the tab and the close button look decent? And can you also try tabs with the system's dark mode? |
|
Hovering on X: |
|
Okay so we need more changes to make it work for Mac. Perhaps we can do this in person sometime? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #323