Allow scanning codes that are color inverted #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's nice! Have you tested that? |
|
What is the status of this? This would be extremely helpful for my current project. |
|
Can somebody test this and confirm that it works correctly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used inverted luminance for all even frames to handle the case that the code being scanned is color inverted. For production, that should be made as an option, sorry I didn't walk through the entire library to learn how to do it.
P.S. I duplicated the loop for converting pixels, because I think that hurts performance a bit if the odd-even branching is made for every pixel. Not sure of that, I am not a TS guy. :) This is the first time for me to write TS code.