Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DefaultDynamicLinqCustomTypeProvider constructor to be compatible with microsoft/RulesEngine #833

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Jul 29, 2024

No description provided.

@StefH StefH added the feature label Jul 29, 2024
@StefH StefH self-assigned this Jul 29, 2024
@StefH StefH changed the title Update DefaultDynamicLinqCustomTypeProvider to make ParsingConfig optional Update DefaultDynamicLinqCustomTypeProvider constructor to be compatible with microsoft/RulesEngine Jul 29, 2024
Copy link

@aligneddev aligneddev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like it will handle the issue to me.

@StefH
Copy link
Collaborator Author

StefH commented Jul 29, 2024

That looks like it will handle the issue to me.

To be 100% sure, I did create a preview (System.Linq.Dynamic.Core.1.4.4-preview-01) which can be downloaded from MyGet:
https://www.myget.org/F/system-linq-dynamic-core/api/v3/index.json

Can you test this?

@nmadland
Copy link

Yes will do. Thank you.

@nmadland
Copy link

nmadland commented Jul 29, 2024

We should be back in business. Thank you. Will your SonarCloud check step need to be fixed?

@StefH
Copy link
Collaborator Author

StefH commented Jul 29, 2024

Does it work as before?

@StefH
Copy link
Collaborator Author

StefH commented Jul 29, 2024

Fixing SonarCloud is not needed, because I actually introduced a obsolete and not-used method ;-)

@nmadland
Copy link

Yes it does. Thank you.

@StefH StefH merged commit 06610fb into master Jul 29, 2024
4 of 5 checks passed
@StefH StefH deleted the bug/830-DefaultDynamicLinqCustomTypeProvider branch July 29, 2024 18:41
@nmadland
Copy link

Any idea when a new version will be published to nuget?

@StefH
Copy link
Collaborator Author

StefH commented Jul 29, 2024

Any idea when a new version will be published to nuget?

probably in a few days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants