Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci workflows #208

Closed
wants to merge 54 commits into from
Closed

Conversation

leovct
Copy link
Member

@leovct leovct commented Aug 6, 2024

Description

CI Workflows

  • Speed up the deploy jobs by setting l1_seconds_per_slot to 1s.
  • Add timeouts to each job, especially the deploy jobs - 20 minutes timeout.
  • FIx nightly workflow.

Documentation

  • Set back l1_seconds_per_slot to 12s in our configuration file but mention to set it to 1, in the README, when deploying the CDK stack.
  • Document sequencer_type in params.yml.
  • Update README instructions to work with the new cdk environment.
  • Add a doc to explain how to deploy the old zkevm sequencer.

Scripts

  • Transform the monitor-cdk-verified-batches local action into a script. Imo, it's easier to use and maintain.
  • Improve the monitor-verified-batches.sh script.
    • It now requires an RPC URL instead of the name of the rpc service to query. This flag is mandatory.
    • It shows the script input values for debug purposes.
    • It shows the different batch counters (latest batch number on L2, virtual and verified batches).
  • Improve compare_default_params.sh script.

New output:

Extracting default parameters from input_parser.star...
Extracting default parameters from kurtosis.yml...
Extracting default parameters from params.yml...


🔍 Comparing .params.yml and .input_parser.star...

3 differences found:

📄 .params.yml (source of truth)
--------------------------------------------------------------------------------
zkevm_sequence_sender_image: hermeznetwork/zkevm-sequence-sender:v0.2.0-RC5
cdk_erigon_node_image: hermeznetwork/cdk-erigon:2.0.0-beta16
toolbox_image: leovct/toolbox:0.0.2

📄 .input_parser.star (🚨 to be updated 🚨)
--------------------------------------------------------------------------------
zkevm_sequence_sender_image: hermeznetwork/zkevm-sequence-sender:v0.2.0-RC4
cdk_erigon_node_image: hermeznetwork/cdk-erigon:2.0.0-beta15
toolbox_image: leovct/toolbox:0.0.1


🔍 Comparing .params.yml and .kurtosis.yml...

3 differences found:

📄 .params.yml (source of truth)
--------------------------------------------------------------------------------
zkevm_sequence_sender_image: hermeznetwork/zkevm-sequence-sender:v0.2.0-RC5
cdk_erigon_node_image: hermeznetwork/cdk-erigon:2.0.0-beta16
toolbox_image: leovct/toolbox:0.0.2

📄 .kurtosis.yml (🚨 to be updated 🚨)
--------------------------------------------------------------------------------
zkevm_sequence_sender_image: hermeznetwork/zkevm-sequence-sender:v0.2.0-RC4
cdk_erigon_node_image: hermeznetwork/cdk-erigon:2.0.0-beta15
toolbox_image: leovct/toolbox:0.0.7

Old output:

Dumping default parameters...

Diff input-parser-args.yml <> params-args.yml
15,17c15,17
< zkevm_sequence_sender_image: hermeznetwork/zkevm-sequence-sender:v0.2.0-RC4
< cdk_erigon_node_image: hermeznetwork/cdk-erigon:2.0.0-beta15
< toolbox_image: leovct/toolbox:0.0.1
---
> zkevm_sequence_sender_image: hermeznetwork/zkevm-sequence-sender:v0.2.0-RC5
> cdk_erigon_node_image: hermeznetwork/cdk-erigon:2.0.0-beta16
> toolbox_image: leovct/toolbox:0.0.2

Diff kurtosis-args.yml <> params-args.yml
15,17c15,17
< zkevm_sequence_sender_image: hermeznetwork/zkevm-sequence-sender:v0.2.0-RC4
< cdk_erigon_node_image: hermeznetwork/cdk-erigon:2.0.0-beta15
< toolbox_image: leovct/toolbox:0.0.7
---
> zkevm_sequence_sender_image: hermeznetwork/zkevm-sequence-sender:v0.2.0-RC5
> cdk_erigon_node_image: hermeznetwork/cdk-erigon:2.0.0-beta16
> toolbox_image: leovct/toolbox:0.0.2

References (if applicable)

https://0xpolygon.slack.com/archives/C060ZAVAU9K/p1722846740784669

@leovct leovct changed the title ci: improve deploy workflows ci: improve ci workflows Aug 7, 2024
@leovct leovct changed the title ci: improve ci workflows fix: ci workflows Aug 8, 2024
@leovct
Copy link
Member Author

leovct commented Aug 8, 2024

(edited)

✅ CI checks look good.

Running the nightly workflow to see if it's working...
https://github.com/leovct/kurtosis-cdk/actions/runs/10310424676

@leovct
Copy link
Member Author

leovct commented Aug 14, 2024

PR broken down into multiple PRs (#221, #220, #219 and #218)

@leovct leovct closed this Aug 14, 2024
@leovct leovct deleted the debug/vcastell-use-cdk-2 branch August 14, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant