Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enhance readability of compare_default_params.sh script output #218

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

leovct
Copy link
Member

@leovct leovct commented Aug 13, 2024

Description

New output:

Extracting default parameters from input_parser.star...
Extracting default parameters from kurtosis.yml...
Extracting default parameters from params.yml...


🔍 Comparing .params.yml and .input_parser.star...

3 differences found:

📄 .params.yml (source of truth)
--------------------------------------------------------------------------------
zkevm_sequence_sender_image: hermeznetwork/zkevm-sequence-sender:v0.2.0-RC5
cdk_erigon_node_image: hermeznetwork/cdk-erigon:2.0.0-beta16
toolbox_image: leovct/toolbox:0.0.2

📄 .input_parser.star (🚨 to be updated 🚨)
--------------------------------------------------------------------------------
zkevm_sequence_sender_image: hermeznetwork/zkevm-sequence-sender:v0.2.0-RC4
cdk_erigon_node_image: hermeznetwork/cdk-erigon:2.0.0-beta15
toolbox_image: leovct/toolbox:0.0.1


🔍 Comparing .params.yml and .kurtosis.yml...

3 differences found:

📄 .params.yml (source of truth)
--------------------------------------------------------------------------------
zkevm_sequence_sender_image: hermeznetwork/zkevm-sequence-sender:v0.2.0-RC5
cdk_erigon_node_image: hermeznetwork/cdk-erigon:2.0.0-beta16
toolbox_image: leovct/toolbox:0.0.2

📄 .kurtosis.yml (🚨 to be updated 🚨)
--------------------------------------------------------------------------------
zkevm_sequence_sender_image: hermeznetwork/zkevm-sequence-sender:v0.2.0-RC4
cdk_erigon_node_image: hermeznetwork/cdk-erigon:2.0.0-beta15
toolbox_image: leovct/toolbox:0.0.7

Old output:

Dumping default parameters...

Diff input-parser-args.yml <> params-args.yml
15,17c15,17
< zkevm_sequence_sender_image: hermeznetwork/zkevm-sequence-sender:v0.2.0-RC4
< cdk_erigon_node_image: hermeznetwork/cdk-erigon:2.0.0-beta15
< toolbox_image: leovct/toolbox:0.0.1
---
> zkevm_sequence_sender_image: hermeznetwork/zkevm-sequence-sender:v0.2.0-RC5
> cdk_erigon_node_image: hermeznetwork/cdk-erigon:2.0.0-beta16
> toolbox_image: leovct/toolbox:0.0.2

Diff kurtosis-args.yml <> params-args.yml
15,17c15,17
< zkevm_sequence_sender_image: hermeznetwork/zkevm-sequence-sender:v0.2.0-RC4
< cdk_erigon_node_image: hermeznetwork/cdk-erigon:2.0.0-beta15
< toolbox_image: leovct/toolbox:0.0.7
---
> zkevm_sequence_sender_image: hermeznetwork/zkevm-sequence-sender:v0.2.0-RC5
> cdk_erigon_node_image: hermeznetwork/cdk-erigon:2.0.0-beta16
> toolbox_image: leovct/toolbox:0.0.2

References (if applicable)

@leovct leovct requested a review from a team August 13, 2024 13:10
Copy link
Contributor

@rebelArtists rebelArtists left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leovct leovct merged commit f99ba55 into 0xPolygon:main Aug 13, 2024
4 of 5 checks passed
@leovct leovct deleted the fix/compare-default-param-scripts branch August 13, 2024 13:37
@leovct leovct mentioned this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants