rewrite ZeroEx in Yul #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarx
requested review from
abandeali1,
dorothy-zbornak,
hysz and
moodlezoup
as code owners
moodlezoup
approved these changes
Nov 5, 2020
dorothy-zbornak
approved these changes
Nov 5, 2020
hysz
reviewed
Nov 5, 2020
dorothy-zbornak
approved these changes
Nov 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a Yul rewrite of the
ZeroExcontract. This saves about 1,000 gas as compared to the Solidity implementation.The function
getFunctionImplementation(bytes4)has been moved out intoSimpleFunctionRegistryFeature.Testing instructions
From
contracts/zero-ex,yarn build && yarn test.There are no new tests. No functionality should change from the previous implementation except the removal of
getFunctionImplementation(bytes4).Types of changes
Checklist:
[WIP]if necessary.