Relay partially failed htlcs when closing #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a channel closes when we've received an UpdateFailHtlc, signed it but not yet received our peer's revocation, we need to fail the htlc upstream. That specific scenario was not correctly handled, resulting in upstream htlcs that were not failed which would force our upstream peer to close the channel.
Codecov Report
@@ Coverage Diff @@
## master #1706 +/- ##
==========================================
- Coverage 86.18% 86.05% -0.13%
==========================================
Files 151 151
Lines 11527 11527
Branches 500 508 +8
==========================================
- Hits 9934 9920 -14
- Misses 1593 1607 +14
|
I don't think we can. What if the peer publishes its previous commitment (that isn't revoked) and uses the preimage? |
He can't, we waited for our local commit to be confirmed ;) |
Well then yes. Alright, you got me I didn't go past the PR description |
pm47
reviewed
Feb 24, 2021
eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala
Outdated
Show resolved
Hide resolved
pm47
approved these changes
Feb 24, 2021
tompro
pushed a commit
to tompro/eclair
that referenced
this pull request
Mar 7, 2021
If a channel closes when we've received an UpdateFailHtlc, signed it but not yet received our peer's revocation, we need to fail the htlc upstream. That specific scenario was not correctly handled, resulting in upstream htlcs that were not failed which would force our upstream peer to close the channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a channel closes when we've received an
UpdateFailHtlc, signed it but not yet received our peer's revocation, we need to fail the htlc upstream.That specific scenario was not correctly handled, resulting in upstream htlcs that were not failed which would force our upstream peer to close the channel.
In that scenario the HTLC is in the
remoteCommitbut not in thenextRemoteCommit.