Detect partially failed htlcs when closing #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a channel closes when we've received an UpdateFailHtlc, signed it but not yet received our peer's revocation, we need to consider that htlc failed. That specific scenario was not correctly handled, resulting in payments that were not failed and were kept pending forever.
sstone
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a channel closes when we've received an UpdateFailHtlc, signed it but not yet received our peer's revocation, we need to consider that htlc failed.
That specific scenario was not correctly handled, resulting in payments that were not failed and were kept pending forever.
In that scenario the HTLC is in the remoteCommit but not in the nextRemoteCommit.
See ACINQ/eclair#1706