370 - Add getDatasetState helper for the dataset lifecycle #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nozomione
changed the base branch from
dev
to
nozomione/361-decouple-format-experiments-from-dataset-manager
nozomione
commented
Sep 30, 2024
|
|
||
| const isExpired = moment(expiredOn).isBefore(Date.now()) | ||
| const isComplete = isProcessed && isAvailable && success // successfully processed | ||
| const isProcessingError = success === false // failed during processing |
There was a problem hiding this comment.
I am thinking about renaming this to hasProcessingError. I originally matched it with other property names (using the is prefix), but I think renaming might be a better fit!
4 tasks
…per and adjust the codebase, use getDatasetState helper to show DownloadDatasetButton for non-errored unprocessed dataset, use getDatasetState helper to show DatasetRegenerateDownloadOptionsForm and remove its 'show' prop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Epic: #358
Closes #370
Merged into the feature branch:
feature/epic-refactor-dataset-page-data-handlingBase & target branch:
nozomione/361-decouple-format-experiments-from-dataset-managerPurpose/Implementation Notes
I've add
helpers/getDatasetStateto facilitate UI rendering and replaced the local variables / destructuring ofdatasetfrom the components with this new helper.Types of changes
Functional tests
N/A
Checklist
Screenshots
N/A