Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable salmon tests #1366

Merged
merged 6 commits into from
Jul 2, 2019
Merged

Reenable salmon tests #1366

merged 6 commits into from
Jul 2, 2019

Conversation

kurtwheeler
Copy link
Contributor

Issue Number

#1293

Purpose/Implementation Notes

In #1293 we upgraded the version of salmon. We wanted to run a staging test to get enough data to be able to verify that the new version was good. However, the transcriptome indices we use in our tests were built with the old salmon version, so we disabled the salmon tests temporarily. The new version ended up being fine, but we forgot to reenable the salmon tests.

When I was trying to reenable the salmon tests I couldn't get the reference files to work, but then I looked at them and they only had 16 genes so I just replaced them with new files created by running the tests.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Functional tests

The tests work again I think!!!

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@wvauclain wvauclain merged commit b88e486 into dev Jul 2, 2019
@wvauclain wvauclain deleted the kurtwheeler/reenable-salmon-tests branch July 2, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants