MCH standalone alignment module #12583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elros60
added a commit
to Elros60/AliceO2
that referenced
this pull request
Jan 23, 2024
Please consider the following formatting changes to AliceO2Group#12583
pillot
previously approved these changes
Jan 24, 2024
There was a problem hiding this comment.
The approval is just to trigger the CI. Since it is your first PR, it does not start automatically.
Why is there 2 levels of directories: Align/Aligner/? There should be only one: Align/.
I don't really understand the workflow. It works more like a single executable, looping through the TF itself, than a DPL workflow. Or do I miss something?
|
Error while checking build/O2/fullCI for f6cf68a at 2024-01-24 12:26: Full log here. |
|
Hi, I see most of this PR is a clone of my custom millepede 2 implementation from the aliroot. |
|
Hi @shahor02, Yes you have a point. For our needs the MillePede2 from AliRoot is enough. And when we checked your O2 implementation of MillePede2 it was not straightforward to adopt it for us. The code committed by Andry is instead very close to ours and it will not be too complicated to use it. Cheers, |
|
Hi Javier, Yes, the O2 interface to the external (official) MP2 is overly complicated, I realize it was not a good idea to try to port aliroot interface to O2 instead of writing it from scratch. Cheers, |
with a common part(for both MCH and MTF) of mathematics basic codes moved to a common path under O2/Detectors/ForwardAlign Co-Authored-By: javierecc <javier.castillo.castellanos@cern.ch>
|
Hi, |
|
Dear all, Cheers, |
|
Error while checking build/O2/fullCI for 46ab7a3 at 2024-02-21 15:38: Full log here. |
shahor02
previously approved these changes
Feb 21, 2024
pillot
reviewed
Feb 21, 2024
|
Error while checking build/O2/fullCI for eeec208 at 2024-02-21 21:35: Full log here. |
…l QA plots to O2Physics task
pillot
reviewed
Feb 28, 2024
pillot
previously approved these changes
Feb 28, 2024
|
Error while checking build/O2/fullCI for 402712f at 2024-02-28 21:11: Full log here. |
|
Dear experts, |
|
@Elros60 , the o2 error is unrelated but the fullCI tells that the coding guidelines are not respected: |
shahor02
approved these changes
Mar 8, 2024
pillot
approved these changes
Mar 9, 2024
andreasmolander
pushed a commit
to andreasmolander/AliceO2
that referenced
this pull request
Apr 12, 2024
* MCH standalone alignment module with a common part(for both MCH and MTF) of mathematics basic codes moved to a common path under O2/Detectors/ForwardAlign Co-Authored-By: javierecc <javier.castillo.castellanos@cern.ch> * Please consider the following formatting changes (#4) * Removed from PR * Fixing formatting issue * Add missing header for filesystem * Fix warning with dereferenced iterator * Remove re-initialisation of magfield for trackfitter and move residual QA plots to O2Physics task * Update comment for track selection * Remove unused function * Remove re-definition of magfield which is set already with CCDB finalisation * Fixing CI build errors --------- Co-authored-by: javierecc <javier.castillo.castellanos@cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
andreasmolander
pushed a commit
to andreasmolander/AliceO2
that referenced
this pull request
Apr 12, 2024
* MCH standalone alignment module with a common part(for both MCH and MTF) of mathematics basic codes moved to a common path under O2/Detectors/ForwardAlign Co-Authored-By: javierecc <javier.castillo.castellanos@cern.ch> * Please consider the following formatting changes (#4) * Removed from PR * Fixing formatting issue * Add missing header for filesystem * Fix warning with dereferenced iterator * Remove re-initialisation of magfield for trackfitter and move residual QA plots to O2Physics task * Update comment for track selection * Remove unused function * Remove re-definition of magfield which is set already with CCDB finalisation * Fixing CI build errors --------- Co-authored-by: javierecc <javier.castillo.castellanos@cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
mwinn2
pushed a commit
to mwinn2/AliceO2
that referenced
this pull request
Apr 25, 2024
* MCH standalone alignment module with a common part(for both MCH and MTF) of mathematics basic codes moved to a common path under O2/Detectors/ForwardAlign Co-Authored-By: javierecc <javier.castillo.castellanos@cern.ch> * Please consider the following formatting changes (#4) * Removed from PR * Fixing formatting issue * Add missing header for filesystem * Fix warning with dereferenced iterator * Remove re-initialisation of magfield for trackfitter and move residual QA plots to O2Physics task * Update comment for track selection * Remove unused function * Remove re-definition of magfield which is set already with CCDB finalisation * Fixing CI build errors --------- Co-authored-by: javierecc <javier.castillo.castellanos@cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for adding the whole MCH stand-alone alignment module enabling us to do the alignment procedure for muon spectrometer with a relatively simple and multi-function workflow.