Digitizer mch #4
Conversation
|
Hi, |
|
@aphacetche: should be fine now. |
| }); | ||
| return mDigits.size(); | ||
| return ndigits; |
There was a problem hiding this comment.
don't understand why you changed back to an extra variable to count the elements : the vector does know its size just fine, doesn't it ?
There was a problem hiding this comment.
Hi,
The reason is that I want to count per hit and not the total. The vector accumulates the entries over several hits.
| int ndigits = processHit(hit, detID, mEventTime); | ||
| //TODO need one label per Digit | ||
| // can use nDigit output of processHit | ||
| for ( int i=0; i<ndigits; ++i ) { |
There was a problem hiding this comment.
ok, I'm getting confused here.
First, I would change the name of the data member mMCTruthContainer to make it clearer what it is a container for, e.g. something like mTrackLabels ?
Next, the label construction should happen outside of the loop.
There was a problem hiding this comment.
Ok, I will have a look later.
There was a problem hiding this comment.
Ok, for the generation, sorry.
I renamed it also now.
Is there something else, which is strange to you?
There was a problem hiding this comment.
Ok, shall I do a PR with this already or do we wait for other developments?
About pile-up, I wrote a novel on JIRA, so might have a look and let me know what are the time scales.
There was a problem hiding this comment.
You can do a PR. Not 100% sure I’ll be able to review it next week, we’ll see.
For your novel, I’ll read it after my holidays ;-)
|
@mwinn2 sorry for the late reply btw, I did not get the direct notification as my handle is not @aphacetche but @aphecetche ;-) |
|
Ok, thanks. Have a nice break. |
* MCH standalone alignment module with a common part(for both MCH and MTF) of mathematics basic codes moved to a common path under O2/Detectors/ForwardAlign Co-Authored-By: javierecc <javier.castillo.castellanos@cern.ch> * Please consider the following formatting changes (#4) * Removed from PR * Fixing formatting issue * Add missing header for filesystem * Fix warning with dereferenced iterator * Remove re-initialisation of magfield for trackfitter and move residual QA plots to O2Physics task * Update comment for track selection * Remove unused function * Remove re-definition of magfield which is set already with CCDB finalisation * Fixing CI build errors --------- Co-authored-by: javierecc <javier.castillo.castellanos@cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
* MCH standalone alignment module with a common part(for both MCH and MTF) of mathematics basic codes moved to a common path under O2/Detectors/ForwardAlign Co-Authored-By: javierecc <javier.castillo.castellanos@cern.ch> * Please consider the following formatting changes (#4) * Removed from PR * Fixing formatting issue * Add missing header for filesystem * Fix warning with dereferenced iterator * Remove re-initialisation of magfield for trackfitter and move residual QA plots to O2Physics task * Update comment for track selection * Remove unused function * Remove re-definition of magfield which is set already with CCDB finalisation * Fixing CI build errors --------- Co-authored-by: javierecc <javier.castillo.castellanos@cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Hi @aphecetche ,
this is the most naive implementation.
It is very ugly in Digitizer.cxx to have this loop into the loop. Alternatively, one could give the process Hit also the MClabel COntainer and fill it inside the digit loop. This is certainly faster, but I am not sure, if this not becomes quite ugly in terms of reading.
let me know.