Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test that verifies overriding by using ConfigureTelemetry #1787

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

martintmk
Copy link
Contributor

The issue or feature being addressed

Contributes to #1783

Details on the issue fix or feature implementation

In this test I try to to very that calling ConfigureTelemetry always wins even when using the AddResiliencePipeline extension to define a pipeline.

The idea is that no matter what ILoggerFactory is defined in DI, calling ConfigureTelemetry explicitly always wins.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (56890d8) 84.56% compared to head (3ff7cf7) 84.56%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1787   +/-   ##
=======================================
  Coverage   84.56%   84.56%           
=======================================
  Files         308      308           
  Lines        6791     6791           
  Branches     1044     1044           
=======================================
  Hits         5743     5743           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 84.56% <ø> (ø)
macos 84.56% <ø> (ø)
windows 84.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintmk martintmk merged commit 2a81c43 into main Nov 14, 2023
18 checks passed
@martintmk martintmk deleted the mtomka/override-logger-factory branch November 14, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants