Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test that verifies overriding by using ConfigureTelemetry #1787

Merged
merged 1 commit into from
Nov 14, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.DependencyInjection.Extensions;
using Microsoft.Extensions.Logging;
using Polly.Registry;

namespace Polly.Extensions.Tests.Issues;

public partial class IssuesTests
{
[Fact]
public void OverrideLoggerFactory_ByExplicitConfigureTelemetryCall_1783()
{
// Arrange
using var loggerFactory1 = new FakeLoggerFactory();
using var loggerFactory2 = new FakeLoggerFactory();
var services = new ServiceCollection();
services.TryAddSingleton<ILoggerFactory>(loggerFactory1);

// Act
services.AddResiliencePipeline("dummy", builder =>
{
builder.AddTimeout(TimeSpan.FromSeconds(1));

// This call should override the base factory
builder.ConfigureTelemetry(loggerFactory2);
});

// Assert
var provider = services.BuildServiceProvider().GetRequiredService<ResiliencePipelineProvider<string>>();

provider.GetPipeline("dummy").Execute(() => { });

loggerFactory1.FakeLogger.GetRecords().Should().BeEmpty();
loggerFactory2.FakeLogger.GetRecords().Should().NotBeEmpty();
}
}