Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blimp: Remove previous flight mode #28078

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Blimp: Remove previous flight mode #28078

merged 1 commit into from
Sep 19, 2024

Conversation

peterbarker
Copy link
Contributor

No description provided.

@MattKear
Copy link
Contributor

@MichelleRos, are you happy with this PR? I am keen that this goes in, so I can remove the commit from #27786.
The prev_control_mode variable was added by me in copter for autorotations. I am looking to remove the functionality in copter that depended on this variable. In tidying up I spotted that it was in blimp and not used.

@MattKear MattKear added the Blimp label Sep 19, 2024
MichelleRos
MichelleRos approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@MichelleRos MichelleRos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, absolutely fine. Sorry I missed adding the approval earlier.

@rmackay9 rmackay9 merged commit 4eba87d into ArduPilot:master Sep 19, 2024
57 checks passed
@rmackay9
Copy link
Contributor

Merged, thanks!

@MattKear
Copy link
Contributor

Thank you :-)

@peterbarker peterbarker deleted the pr/remove-unsued-blimp-prevmode branch September 19, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amilcarlucas amilcarlucas amilcarlucas approved these changes

@MichelleRos MichelleRos MichelleRos approved these changes

Assignees

@MichelleRos MichelleRos

Labels
Blimp DevCallEU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peterbarker @MattKear @rmackay9 @amilcarlucas @MichelleRos