Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix divide by zero in walker model #154

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Bugfix divide by zero in walker model #154

merged 2 commits into from
Jan 12, 2023

Conversation

reverendbedford
Copy link
Collaborator

Missed an instance of flow direction = s / n, fixed with an explicit if statement as that seems to be what I did elsewhere in this model.

Missed an instance of flow direction = s / n, fixed with an explicit if
statement as that seems to be what I did elsewhere in this model.
@reverendbedford reverendbedford force-pushed the bugfix_walker branch 3 times, most recently from d9595f0 to 5f08d7f Compare January 11, 2023 23:06
Copy link
Contributor

@bwspenc bwspenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good to me -- preferable to adding epsilon to the divisor in my opinion. Thanks for taking care of this!

@reverendbedford reverendbedford force-pushed the bugfix_walker branch 3 times, most recently from 45682e5 to a27d742 Compare January 12, 2023 03:06
@reverendbedford
Copy link
Collaborator Author

I hate Apple, but this should pass now. I'll merge tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants