send notification for put group membership decision #2742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandrasekhar1996
force-pushed
the
pendingGroupMemberActionNotification
branch
2 times, most recently
from
c6c7240
to
5c67050
Compare
havetisyan
requested changes
Sep 28, 2024
...ms/src/main/java/com/yahoo/athenz/zms/notification/MembershipDecisionNotificationCommon.java
Show resolved
Hide resolved
servers/zms/src/main/java/com/yahoo/athenz/zms/store/impl/jdbc/JDBCConnection.java
Outdated
Show resolved
Hide resolved
Signed-off-by: craman <chandrasekhar.raman@yahooinc.com>
chandrasekhar1996
force-pushed
the
pendingGroupMemberActionNotification
branch
from
5c67050
to
8d3e40a
Compare
havetisyan
approved these changes
Sep 28, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Purpose of the pull request is to send notifications when an action is taking on a pending group membership. The action can be approving or rejecting a pending member request and the notification should be sent to the original requestor of the pending group member as well as the group member.
Contribution Checklist:
Attach Screenshots (Optional)