during delete tenancy check the primary db instance #2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
MartinTrojans
approved these changes
Sep 28, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when we're checking the tenancy registration, the server would update the primary db instance with the role deletions but then would check the replica for any role existence to remove the domain dependency. if the db was slow and the changes were not propagated immediately, it would think there are still valid resource groups and not remove the dependency. Now we're checking the primary instance as well. Also simplified the calls to look for the roles and remove any unnecessary lookups.
Contribution Checklist:
Attach Screenshots (Optional)