Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks: Add a Tock block #31303

Merged
merged 11 commits into from
Jun 12, 2023
Merged

Blocks: Add a Tock block #31303

merged 11 commits into from
Jun 12, 2023

Conversation

pablinos
Copy link
Contributor

@pablinos pablinos commented Jun 9, 2023

This is adding a Tock block based on the Tock Widget plugin

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1HpG7-n0W-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

With a test site with beta blocks enabled:

  • In the editor, insert a Tock block
  • Add a URL slug like roister or etch
  • Click Set URL
  • Preview the post and check the button works as expected

@pablinos pablinos self-assigned this Jun 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack plugin. Once the plugin is active, go to Jetpack > Jetpack Beta > Jetpack and enable the add/tock-widget-block branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/tock-widget-block
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Block] Tock [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Jun 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

  • Next scheduled release: July 5, 2023.
  • Scheduled code freeze: June 26, 2023.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jun 9, 2023
@pablinos pablinos added [Status] In Progress [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] In Progress labels Jun 9, 2023
jeherve
jeherve previously approved these changes Jun 12, 2023
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Ready to Merge Go ahead, you can push that green button! [Pri] Normal and removed [Status] Needs Team Review labels Jun 12, 2023
@jeherve jeherve mentioned this pull request Jun 12, 2023
3 tasks
@github-actions github-actions bot added [CRM] Portal Module [CRM] Woo Sync Module [Plugin] CRM Issues about the Jetpack CRM plugin Admin Page React-powered dashboard under the Jetpack menu Docker labels Jun 12, 2023
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Jun 12, 2023
jeherve
jeherve previously approved these changes Jun 12, 2023
@pablinos pablinos merged commit 3304246 into trunk Jun 12, 2023
@pablinos pablinos deleted the add/tock-widget-block branch June 12, 2023 15:06
@github-actions github-actions bot added this to the jetpack/12.3 milestone Jun 12, 2023
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jun 12, 2023
@samiff samiff added the [Status] Needs Testing We need to add this change to the testing call for this month's release label Jun 12, 2023
@samiff samiff removed the [Status] Needs Testing We need to add this change to the testing call for this month's release label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management Admin Page React-powered dashboard under the Jetpack menu [Block] Tock [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants