-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker: Change MariaDB version to LTS #31315
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
Similar to #31315 we need to change the version in the post-build action to stop the 'Test plugin upgrades' check from failing.
* [not verified] Tock Block: Add a block for a Tock widget This is an initial version of a Tock block based on the [Tock Widget](https://wordpress.org/plugins/tock-widget/) plugin. * [not verified] Update the styling to handle alignment * [not verified] Swap to using a popover for the URL input * [not verified] Add submit button * [not verified] add translatable string * Following #31315, update the MariaDB version is the post-build action * Fix the example viewport width. * Fix Sandbox refresh in Chrome * Update the notice text. * Change key event to down, so the popover can be triggered by enter. --------- Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Proposed changes:
I ran into an issue where running
jetpack docker up
failed to start MariaDB, because themysqld
binary was not available in the container image.It seems like MariaDB decided to sunset the mysql/mysqld commands in favor of mariadbd/mariadb commands, but didn't update the Docker image to reflect this.
This PR updates the version used from
latest
tolts
.Other information:
Jetpack product discussion
p1686562119649609-slack-C0299DMPG
Does this pull request change what data or activity we track or use?
No
Testing instructions:
jetpack docker up