Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rainfall: Try spacing presets #6293

Merged
merged 3 commits into from
Aug 2, 2022
Merged

Rainfall: Try spacing presets #6293

merged 3 commits into from
Aug 2, 2022

Conversation

scruffian
Copy link
Member

Changes proposed in this Pull Request:

Now that the spacing presets have merged (WordPress/gutenberg#41527) we should start using these in our themes. This is an example of how we could use them in Rainfall...

@scruffian scruffian requested a review from a team July 27, 2022 22:05
@scruffian scruffian self-assigned this Jul 27, 2022
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it's working great. Should we replace the rest of the spacing values in Rainfall (or at least the ones using rem) so they use a preset?

@scruffian
Copy link
Member Author

Should we replace the rest of the spacing values in Rainfall (or at least the ones using rem) so they use a preset?

Go ahead :)

@scruffian
Copy link
Member Author

Thanks @mikachan

@scruffian scruffian merged commit fd085a1 into trunk Aug 2, 2022
@scruffian scruffian deleted the try/spacing-presets branch August 2, 2022 12:08
@mikachan mikachan added this to the Rainfall milestone Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants