-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(5P) FSE: Implement alternate template selector design #35232
Comments
This is large dynamic single preview, with screenshots for small previews. |
@Automattic/ajax I'd like to flag some issues I've noticed with Issues:
|
This is the next iteration designs without the modal from @shaunandrews #35248 |
Small detail but I wanted to share that Modal component already has a native support for buttons which we should leverage in case we add the confirmation step (I'm all for adding it) These are the docs that mention it and show what it looks like - it takes bottom right of the window. https://github.com/WordPress/gutenberg/tree/master/packages/components/src/modal Our modal is a bit more complex than examples but I think we should aim to stick with standards |
If you really want to stick with standards, you might also want to remove the [x] in the top right, and add a cancel button next to the "Use template" button. Then make the buttons persistent with the "use template" button disabled until a template is selected. |
Thanks for this @apeatling. I'm not completely clear on the interaction model though.
Drawing on existing interaction modelsPerhaps we could use the existing WP-Admin Themes model for guidance here? With this approach you:
To be clear I'm not suggesting we copy this design/UX verbatim. Rather I"m saying we can learn from the interactions. Namely:
Interested in everyone's thoughts... We should also be mindful of this UI response time research when working on the UX for this: https://www.nngroup.com/articles/response-times-3-important-limits/ |
Quoting @shaunandrews:
I assume that is what Andy had in mind in terms of the interactions for the new mockups. I would agree with @getdave that there should be some form of visual response when hovering over a thumbnail. Mainly to indicate that they can/should be clicked. |
@apeatling The "x" comes with the standard Gutenberg modal. If we set |
Another thought: how much do we need to "care" about the fine details of the modal if it's going to go anyway? Just thinking... |
Yes, let's not overthink this. What I presented was what Shaun presented for the iteration outside of the modal (option B). It would allow us to more easily move to the non-modal iteration next. |
The visuals I presented came with the caveat: "If hovering proves to be too big of an issue". My suggestions for the above are to:
|
If we can't find a way to improve
BlockPreview
performance enough for it to be shippable (#34976), let's update the design of the template selector to mitigate that concern.The text was updated successfully, but these errors were encountered: