Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(5P) FSE: Explore performance improvement options for BlockPreview #35233

Closed
6 of 8 tasks
obenland opened this issue Aug 8, 2019 · 4 comments
Closed
6 of 8 tasks

(5P) FSE: Explore performance improvement options for BlockPreview #35233

obenland opened this issue Aug 8, 2019 · 4 comments

Comments

@obenland
Copy link
Member

obenland commented Aug 8, 2019

This should be a rather timeboxed task to determine how we can cut down the template selector load time to under 1 second. If we find that it's not possible for us to do so, let's go forward with #35232.

Let's consider researching the following items:

  • Only loading visible contents (maybe the first X Blocks)
  • Dynamically loading full template Blocks only on :hover (interaction)
  • Ability to define X number of Blocks to load
  • Memoization (59beaa8)
  • Small images for thumbnails preview
  • Compare performance loading static images
  • Try adding a new thumbnail field in the endpoint response
  • Move parsing templates content to higher component: https://github.com/Automattic/wp-calypso/pull
@getdave
Copy link
Contributor

getdave commented Aug 12, 2019

Do we have input from @youknowriad on possible avenues to explore here in terms of performance?

@obenland obenland changed the title FSE: Explore performance improvement options for BlockPreview (5P) FSE: Explore performance improvement options for BlockPreview Aug 12, 2019
@getdave
Copy link
Contributor

getdave commented Aug 12, 2019

Some avenues:

  • Only loading visible contents (maybe the first X Blocks)
  • Dynamically loading full template Blocks only on :hover (interaction)
  • Ability to define X number of Blocks to load
  • Memoization

@retrofox
Copy link
Contributor

I've defined the number of blocks to load until 10.

@obenland
Copy link
Member Author

Optimized images and updated json annotation for EN: D31446-code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants