Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPT: remove artificial previewing time #35712

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

retrofox
Copy link
Contributor

@retrofox retrofox commented Aug 22, 2019

Changes proposed in this Pull Request

This PR removes the delay added artificially when it shows the template in the Large preview.

Testing

  1. Apply the changes
  2. create a new page
  3. Switch the template clicking on the thumbnails
  4. Check the Large preview is rendered faster without showing the Loading preview… message.

Issues: #35233

@retrofox retrofox requested review from a team as code owners August 22, 2019 20:00
@matticbot
Copy link
Contributor

@retrofox retrofox changed the title spt: remove all artifical previewing time SPT: remove artificial previewing time Aug 22, 2019
@obenland obenland merged commit fd84db7 into master Aug 22, 2019
@obenland obenland deleted the try/spt-removing-artificial-previewing-time branch August 22, 2019 22:32
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@retrofox
Copy link
Contributor Author

Thanks for taking over of this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants