SPT: move storing to higher component #35618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
retrofox
force-pushed
the
try/spt-move-storing-to-higher-component
branch
from
190de70
to
a5c6419
Compare
retrofox
changed the title
getdave
reviewed
Aug 21, 2019
There was a problem hiding this comment.
I like what you've done here. It really improves things thank you. It's much appreciated.
I've tested manually on my local and it works as required.
One thing I've noted is that we have almost no doc blocks on our component functions. We should probably write some...
...ng-plugin/starter-page-templates/page-template-modal/components/template-selector-control.js
Outdated
Show resolved
Hide resolved
...ll-site-editing/full-site-editing-plugin/starter-page-templates/page-template-modal/index.js
Outdated
Show resolved
Hide resolved
...ll-site-editing/full-site-editing-plugin/starter-page-templates/page-template-modal/index.js
Outdated
Show resolved
Hide resolved
...ll-site-editing/full-site-editing-plugin/starter-page-templates/page-template-modal/index.js
Show resolved
Hide resolved
...ll-site-editing/full-site-editing-plugin/starter-page-templates/page-template-modal/index.js
Outdated
Show resolved
Hide resolved
...ll-site-editing/full-site-editing-plugin/starter-page-templates/page-template-modal/index.js
Show resolved
Hide resolved
...ll-site-editing/full-site-editing-plugin/starter-page-templates/page-template-modal/index.js
Outdated
Show resolved
Hide resolved
...ll-site-editing/full-site-editing-plugin/starter-page-templates/page-template-modal/index.js
Outdated
Show resolved
Hide resolved
marekhrabe
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This PR move the logic which parses the template content from the
<TemplateSelectorItem />to the<PageTemplateModal />.Right now we are processing each template content into its own component (). With processing I mean to get the raw template content (from a component property), parse this content in order to get the blocks, to finally preview them using the component.
In this PR, the templates are re-ordered as an Object which each field is the template slug. This
templatesproperty is passed to the<PageTemplateModal />component, and once the component did mount it starts the parsing process, template by template and storing the blocks into the component state (blocks).The blocks state is passed to the
<TemplateSelectorControl />component through of theblocksByTemplatesproperty, and this component takes over of iterating for all templates in order to perform the preview (thumbnails).All templates are parsed once, and also we are avoiding storing the blocks for the current preview (large preview) since now we just need the current template slug.
Related Issues: #35233
Test
Apply the patch and check that everything is working as expected.
Maybe use the developer tools to check the props and state of the components.