Site Settings: Update Jetpack settings section to use SectionHeader pattern #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alternatekev
added
[Feature] Site Settings
|
Since moving things around affects the Falling Snow feature, I moved that option into the Site Profile section:
|
| @@ -69,6 +69,9 @@ | |||
| font-style: italic; | |||
| font-weight: 400; | |||
| color: $gray; | |||
| &.is-indented{ | |||
|
👍 Code looks good and tested on Chrome, FF, IE11, Edge. Separating the settings into 2 cards makes things a lot clearer. |
| @@ -1,3 +1,9 @@ | |||
| .plugin__installed-on { | |||
| margin-bottom: 16px; | |||
| } | |||
| .disconnect-jetpack-button{ | |||
There was a problem hiding this comment.
Space after { here too, please, and below.
gwwar
added
[Status] Ready to Merge
and removed
[Status] Needs Review
alternatekev
removed
the
[Status] Needs Design Review
…d patterns updated verbiage from Manage Jetpack Monitor Settings to View Jetpack Monitor Settings removed some of the verbiage I'd added to the jetpack disconnection dialog. after seeing the extra copy in the dialog, i decided it didn't work very well and was unnecessary anyway added a space to the scss, and moved the whole file into the right directory, out of assets/stylesheets added space to jetpack button scss
alternatekev
force-pushed
the
update/site-settings-jetpack
branch
from
0d5a46f
to
bdbe6e2
Compare
alternatekev
added a commit
that referenced
this pull request
Dec 15, 2015
Site Settings: Update Jetpack settings section to use SectionHeader pattern
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the area for Jetpack settings looks like this, and is grouped in with Related Posts under an "Other" section:
This PR proposes that we do the following to make this whole thing clearer:
Making the aforementioned changes results in this: