Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Settings: Update Jetpack settings section to use SectionHeader pattern #1480

Merged
merged 1 commit into from
Dec 15, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions assets/stylesheets/_components.scss
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@
@import 'my-sites/sharing/connections/services-group';
@import 'my-sites/sidebar-navigation/style';
@import 'my-sites/site-indicator/style';
@import 'my-sites/site-settings/style';
@import 'my-sites/site-settings/action-panel/style';
@import 'my-sites/site-settings/delete-site-options/style';
@import 'my-sites/site-settings/delete-site/style';
Expand Down
1 change: 0 additions & 1 deletion assets/stylesheets/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
@import 'sections/stats'; // stats page styles
@import 'sections/upgrades'; // upgrades page styles
@import 'sections/sharing'; // sharing page styles
@import 'sections/site-settings'; // blog setting styles
@import 'sections/notifications'; // notifications styles
@import 'sections/checkout'; // Checkout styles
@import 'sections/billing-history'; // Billing History styles
Expand Down
9 changes: 8 additions & 1 deletion client/my-sites/plugins/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -78,4 +78,11 @@

.plugins__plugin-list-state {
white-space: nowrap;
}
}

.disconnect-jetpack-button {
margin-right: 8px;
}
.card.is-compact.section-header.after-compact {
margin-top: 16px;
}
87 changes: 38 additions & 49 deletions client/my-sites/site-settings/form-general.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ module.exports = React.createClass( {
onClick={ this.recordEvent.bind( this, 'Clicked Site Visibility Radio Button' ) }
/>
<span>{ this.translate( 'Discourage search engines from indexing this site' ) }</span>
<p className="settings-explanation inside-list">
<p className="settings-explanation inside-list is-indented">
{ this.translate( 'Note: This option does not block access to your site — it is up to search engines to honor your request.' ) }
</p>
</label>
Expand Down Expand Up @@ -316,36 +316,13 @@ module.exports = React.createClass( {
<label>
<input name="jetpack_sync_non_public_post_stati" type="checkbox" checkedLink={ this.linkState( 'jetpack_sync_non_public_post_stati' ) }/>
<span>{ this.translate( 'Allow synchronization of Posts and Pages with non-public post statuses' ) }</span>
<p className="settings-explanation">{ this.translate( '(e.g. drafts, scheduled, private, etc\u2026)' ) }</p>
<p className="settings-explanation is-indented">{ this.translate( '(e.g. drafts, scheduled, private, etc\u2026)' ) }</p>
</label>
</li>
</ul>
);
},

jetpackOptions: function() {
var site = this.props.site;

if ( ! site.jetpack ) {
return null;
}

return (
<fieldset>
<legend>{ this.translate( 'Jetpack Status' ) }</legend>
{ this.syncNonPublicPostTypes() }
<p>{
this.translate( 'You can also {{manageLink}}manage the monitor settings{{/manageLink}} and {{migrateLink}}migrate followers{{/migrateLink}}.', {
components: {
manageLink: <a href={ '../security/' + site.slug } />,
migrateLink: <a href={ 'https://wordpress.com/manage/' + site.ID } />
}
} )
}</p>
</fieldset>
);
},

jetpackDisconnectOption: function() {
var site = this.props.site,
disconnectText;
Expand All @@ -358,26 +335,11 @@ module.exports = React.createClass( {
context: 'Jetpack: Action user takes to disconnect Jetpack site from .com link in general site settings'
} );

return (
<fieldset>
<legend>{ this.translate( 'Jetpack Connection' ) }</legend>
<ul id="settings-jetpack-connection" className="settings-jetpack">
<li>
<label>
<DisconnectJetpackButton
site={ site }
text= { disconnectText }
redirect= "/stats"
linkDisplay={ false }
/>
<p className="settings-explanation inside-list">
{ this.translate( 'This action cannot be undone. You will need to reconnect manually from your site dashboard.' ) }
</p>
</label>
</li>
</ul>
</fieldset>
);
return <DisconnectJetpackButton
site={ site }
text= { disconnectText }
redirect= "/stats"
linkDisplay={ false } />;
},

holidaySnowOption: function() {
Expand Down Expand Up @@ -435,6 +397,7 @@ module.exports = React.createClass( {
<form onChange={ this.markChanged }>
{ this.siteOptions() }
{ this.languageOptions() }
{ this.holidaySnowOption() }
</form>
</Card>
<SectionHeader label={ this.translate( 'Address and visibility' ) }>
Expand All @@ -456,7 +419,36 @@ module.exports = React.createClass( {
{ this.visibilityOptions() }
</form>
</Card>
<SectionHeader label={ this.translate( 'Other' ) }>
{ this.props.site.jetpack
? <div>
<SectionHeader label={ this.translate( 'Jetpack' ) }>
{ this.jetpackDisconnectOption() }
<Button
compact={ true }
onClick={ this.submitForm }
primary={ true }
type="submit"
disabled={ this.state.fetchingSettings || this.state.submittingForm }>
{ this.state.submittingForm
? this.translate( 'Saving…' )
: this.translate( 'Save Settings' )
}
</Button>
</SectionHeader>
<Card className="is-compact">
<form onChange={ this.markChanged }>
{ this.syncNonPublicPostTypes() }
</form>
</Card>
<Card href={ '../security/' + site.slug } className="is-compact">
{ this.translate( 'View Jetpack Monitor Settings' ) }
</Card>
<Card href={ 'https://wordpress.com/manage/' + site.ID } className="is-compact">
{ this.translate( 'Migrate followers from another WordPress.com blog' ) }
</Card>
</div>
: null }
<SectionHeader className="after-compact" label={ this.translate( 'Related Posts' ) }>
<Button
compact={ true }
onClick={ this.submitForm }
Expand All @@ -471,9 +463,6 @@ module.exports = React.createClass( {
</SectionHeader>
<Card>
<form onChange={ this.markChanged }>
{ this.jetpackOptions() }
{ this.jetpackDisconnectOption() }
{ this.holidaySnowOption() }
{ this.relatedPostsOptions() }
</form>
</Card>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@
font-style: italic;
font-weight: 400;
color: $gray;
&.is-indented {
margin-left: 24px;
}
}

p.settings-alert {
Expand Down