People: Normalize invite create validations in the reducer #3293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, successful validations were normalized when updating the state in the invite form component. But, that could be an issue if the data is needed in more than one place. This PR normalizes the success validations, which can sometimes be return as an object or an array, in the reducer so that components can simply retrieve the data.
ebinnion
added
[Status] Needs Review
| @@ -8,6 +8,16 @@ import { fromJS } from 'immutable'; | |||
| */ | |||
| import { action as ActionTypes } from 'lib/invites/constants'; | |||
|
|
|||
| function normalizeSuccessValidations( validations ) { | |||
There was a problem hiding this comment.
I think we could move it to where RECEIVE_CREATE_INVITE_VALIDATION_SUCCESS is dispatched.
|
Closing in favor of #3540. |
scruffian
removed
the
[Status] Needs Review
This was referenced Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, successful validations were normalized when updating the state in the invite form component. But, that could be an issue if the data is needed in more than one place.
This PR normalizes the success validations, which can sometimes be return as an object or an array, in the reducer so that components can simply retrieve the data.
To test:
update/people-invite-create-validate-normalizzebranch/people/new/$sitelocalStorage.setItem( 'debug', 'calypso:my-sites:people:invites' );in the consolecc @lezama for review since he worked on the initial normalization and has a better handle on the issues.