People: Remove normalization of successful invite validations #3540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the API returned either an array or an object of successful invite validations. Now that the API has been updated to always return an array for successful validations in r131590-wpcom, we can remove this normalization in Calypso.
ebinnion
added
[Status] Needs Review
lezama
added
[Status] Ready to Merge
and removed
[Status] Needs Review
ebinnion
added a commit
that referenced
this pull request
Feb 24, 2016
…ove-success-normalize People: Remove normalization of successful invite validations
ebinnion
deleted the
update/invite-validation-remove-success-normalize
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #3293
Previously, the API returned either an array or an object of successful invite validations. Now that the API has been updated to always return an array for successful validations in r131590-wpcom, we can remove this normalization in Calypso.
To test:
update/people-invite-create-validate-normalizzebranch/people/new/$sitelocalStorage.setItem( 'debug', 'calypso:my-sites:people:invites' );in the consolecc @lezama for review since he worked on the initial normalization and has a better handle on the issues.