Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the usage flag from TCGC directly #4734

Closed
Tracked by #4711
ArcturusZhang opened this issue May 21, 2024 · 1 comment · Fixed by microsoft/typespec#3842
Closed
Tracked by #4711

Use the usage flag from TCGC directly #4734

ArcturusZhang opened this issue May 21, 2024 · 1 comment · Fixed by microsoft/typespec#3842
Assignees
@ArcturusZhang
Labels
DPG/RLC v2.1 Post Gallium work DPG v3 Version 3 of AutoRest C# generator.

Comments

@ArcturusZhang
Copy link
Member

No description provided.

@ArcturusZhang ArcturusZhang mentioned this issue May 21, 2024
Open
@ArcturusZhang ArcturusZhang changed the title Use the usage flag from TCGC direct Use the usage flag from TCGC directly May 21, 2024
@ArcturusZhang ArcturusZhang added v3 Version 3 of AutoRest C# generator. DPG DPG/RLC v2.1 Post Gallium work labels May 21, 2024
@ArcturusZhang ArcturusZhang self-assigned this May 21, 2024
@ArcturusZhang ArcturusZhang mentioned this issue May 21, 2024
Closed
6 tasks
@ArcturusZhang
Copy link
Member Author

Unfortunately this is currently blocked by our patch operations.
We did not include patch operation's convenience method, therefore those methods should not be considered during usage calculation, but currently TCGC does not have a way to let us have the filter.

@ArcturusZhang ArcturusZhang mentioned this issue Jun 21, 2024
Closed
6 tasks
@ArcturusZhang ArcturusZhang mentioned this issue Jul 16, 2024
Merged
github-merge-queue bot pushed a commit to microsoft/typespec that referenced this issue Jul 25, 2024
@ArcturusZhang
Use the UsageFlags from TCGC directly in our emitter (#3842)
f848c5e 
Fixes Azure/autorest.csharp#4820
Fixes Azure/autorest.csharp#4734

This PR changes our the converter logic in our emitter, so that we do
not need to convert the usage flags from TCGC to ours, we directly use
their result. As part of the motivation, a few workaround logic to "fix"
the usages has been removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArcturusZhang ArcturusZhang

Labels
DPG/RLC v2.1 Post Gallium work DPG v3 Version 3 of AutoRest C# generator.
Projects
None yet
Milestone
No milestone
2 participants
@ArcturusZhang @pshao25