-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check the usage of readonly property type in RoundTrip model for DPG #4820
Comments
In current DPG's implementation, ResultModel is generated as a |
Also in today's offline sync up, we kind of have an agreement on the patch convenience methods, therefore we have a way to use the usage from TCGC directly therefore we could expect a final fix for this. |
This should have fixed this issue despite we did not know quite well which part introduces the fix. |
Are you saying csharp emitter has not consumed TCGC usage yet, but the usage still got fixed? |
that statement is not fully correct. We converted the usage value from TCGC to ours (like this) - therefore when tcgc has the fix, we get the changes in DPG as well. |
OK. Then we know the fix is from TCGC. |
Fixes Azure/autorest.csharp#4820 Fixes Azure/autorest.csharp#4734 This PR changes our the converter logic in our emitter, so that we do not need to convert the usage flags from TCGC to ours, we directly use their result. As part of the motivation, a few workaround logic to "fix" the usages has been removed.
TSP:
detailed case can be found in this pr: Azure/cadl-ranch#587
In this case, usage for
ResultModel
should beOutput
instead ofRoundTrip
, because this model is readonly.The text was updated successfully, but these errors were encountered: