feat(generator): flatten model properties #5094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archerzz
requested review from
m-nash,
lirenhe,
ArthurMa1978,
hallipr and
JoshLove-msft
as code owners
archerzz
force-pushed
the
generator/flatten-model-property
branch
from
747af9a
to
5b03a8f
Compare
added 2 commits
September 27, 2024 16:04
This commit will flatten the model property in generator, instead of in the emitter. - Modify `InputModelProperty` - add an `IsFlatten` property for original emitter input - remove `FlattenNames` property from constructor - change model json converter: - convert `TypeSpecInputModelProperty` to `InputModelProperty` - flatten model property if necessary - refactor resolve Azure#4449
archerzz
force-pushed
the
generator/flatten-model-property
branch
from
5b03a8f
to
3f73fe8
Compare
|
Regen preview: Azure/azure-sdk-for-net#46340 No code change |
chunyu3
reviewed
Sep 29, 2024
src/AutoRest.CSharp/Common/Input/InputTypes/Serialization/TypeSpecInputModelTypeConverter.cs
Outdated
Show resolved
Hide resolved
chunyu3
reviewed
Sep 29, 2024
src/AutoRest.CSharp/Common/Input/InputTypes/Serialization/TypeSpecInputModelTypeConverter.cs
Show resolved
Hide resolved
src/AutoRest.CSharp/Common/Input/InputTypes/Serialization/TypeSpecInputModelTypeConverter.cs
Show resolved
Hide resolved
added 4 commits
October 9, 2024 15:43
…a multipart change flattened property to optional if parent property is optional Revert "change flattened property to optional if parent property is optional" This reverts commit 88f936285aec19635ade3a2ba6194a6985a31cdc.
ArcturusZhang
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit will flatten the model property in generator, instead of in the emitter.
InputModelPropertyIsFlattenproperty for original emitter inputFlattenNamesproperty from constructorTypeSpecInputModelPropertytoInputModelPropertyresolve #4788
Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?