refactor(http-client-csharp): do not flatten property in emitter #4449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per discussion, we thought we should not flatten properties in emitter, to keep it as simple as possible. The flattening logic should be implemented in generator. part of Azure/autorest.csharp#4788
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
|
Do not merge. It requires subsequent changes in |
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
…mitter # Conflicts: # packages/http-client-csharp/emitter/src/lib/converter.ts
OK. Subsequent PR is ready: Azure/autorest.csharp#5094 |
chunyu3
reviewed
Sep 27, 2024
...lient-csharp/generator/Microsoft.Generator.CSharp.Input/src/InputTypes/InputModelProperty.cs
Outdated
Show resolved
Hide resolved
added 4 commits
September 29, 2024 10:42
chunyu3
approved these changes
Oct 9, 2024
archerzz
deleted the
http-client-csharp/not-flatten-property-in-emitter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion, we thought we should not flatten properties in emitter, to keep it as simple as possible.
The flattening logic should be implemented in generator.
part of Azure/autorest.csharp#4788